1.5.0: arm64 + dynamic CloudFront source URL (LOC-6563)#39
Open
yashdsaraf wants to merge 2 commits into
Open
Conversation
- New FetchDownloadSourceUrl module POSTs to /binary/api/v1/endpoint to discover the current CDN base URL (CloudFront primary; CloudFlare requested as fallback via X-Local-Fallback-Cloudflare header on retry). - Linux arm64 host now downloads BrowserStackLocal-linux-arm64. Branch order mirrors Node SDK: arm64 wins over alpine on musl. - proxyHost/proxyPort from Local#start now also flow into the binary download (previously ignored for download, used only for running binary). - User-Agent: browserstack-local-ruby/<version> on endpoint POST + GET. - TLS verification now enforced (VERIFY_PEER); was VERIFY_NONE. CHANGELOG calls this out for users on broken trust stores. Tracks LOC-6563. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7 tasks
Net::HTTP defaults to 60s open + 60s read. A hung local.browserstack.com or CDN can stall the binary download for multiple minutes before the user sees an error. - fetch_download_source_url.rb: open_timeout=10, read_timeout=15 (small JSON response, fast) - localbinary.rb download_to: open_timeout=10, read_timeout=30 (read_timeout bounds per-read stalls, not total transfer) Code review finding from LOC-6563 review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RbConfig::CONFIG['host_cpu'] =~ /arm64|aarch64/selectsBrowserStackLocal-linux-arm64. Branch order mirrors the Node SDK (arm64 wins over alpine on musl).BrowserStack::FetchDownloadSourceUrlPOSTs tolocal.browserstack.com/binary/api/v1/endpointto discover the current CDN base. CloudFront is the primary; CloudFlare is requested as fallback on the 5th-remaining retry viaX-Local-Fallback-Cloudflare: trueheader +error_messagebody field. Joins the Node SDK pattern that has been in prod for years.proxyHost/proxyPortfromLocal#startare now also threaded into the endpoint POST and binary GET. Users behind a forward proxy can now download (was: proxy was only applied to the running binary, not the download).browserstack-local-ruby/<version>header on both the endpoint POST and the binary GET. Helps server-side telemetry attribute downloads by binding+version.OpenSSL::SSL::VERIFY_PEER). Previous releases usedVERIFY_NONE. The new POST carries the user'sauth_token— shipping that under VERIFY_NONE would have been a security regression. CHANGELOG calls this out; users relying on disabled verification can pin to 1.4.3.Background
Tracks LOC-6563. C# parity PR ships in coordination — see browserstack-local-csharp #LOC-6563.
Files
Test plan
🤖 Generated with Claude Code